fix(detector): detect generator send replay#43
Closed
prasannakotyal wants to merge 1 commit into
Closed
Conversation
KernelGuard Blue Evaluation
|
Collaborator
|
Thanks for the KernelGuard Flywheel Campaign contribution. This PR is now superseded by the consolidated rule-family implementation in #273, which folds this detector coverage together with the related passing-eval variants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targets KG red #75, where
custom_kernelreturns_g.send(data)from a module-level primed generator. The generator frame stores the first output and subsequent timed calls replay that saved value.This adds a narrow
GENERATOR_SEND_REPLAYdetector. It requires:yieldnext(g)org.send(None)g.send(<input parameter>)The last condition keeps normal coroutine-style generators that compute on every send out of scope.
KernelGuard-Red-Submission: 75
Local verification
red_01_generator_replay->GENERATOR_SEND_REPLAY,should_filter=Trueclean_generator_helper-> staysvalidclean_coroutine_send-> staysvalidclean_unprimed_generator-> staysvalidpython -m py_compile kernelguard.py